Improve Vue Layout renderer reactivity and Vue HTML output #1733
+286
−356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheZoker If possible add testcases for this and the remaining layout attributes. |
sdirix
force-pushed
the
fix-layout-rerender
branch
2 times, most recently
from
68010fa
to
b3fc58e
Compare
Refactor the composition architecture to be based on 'computed' instead of 'ref'. This avoids manually syncing ref content and fixes rerendering issues for the layout renderers.
Make sure that only expected props are handed over to renderers which unconditionally bind all properties. This avoids rendering stringified attributes like rootSchema in the HTML.
sdirix
force-pushed
the
fix-layout-rerender
branch
from
b3fc58e
to
ad7c5d9
Compare
sdirix
changed the title
TheZoker
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the composition architecture to be based on 'computed' instead
of 'ref'. This avoids manually syncing ref content and fixes
rerendering issues for the layout renderers.
Make sure that only expected props are handed over to renderers
which unconditionally bind all properties. This avoids rendering
stringified attributes like rootSchema in the HTML.